DM-35569: ip_isr doEmpiricalReadNoise fails if an amplifier is fully masked #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
approved these changes
Sep 13, 2022
| self.assertEqual(ipIsr.countMaskedPixels(mi, 'BAD'), 0) | ||
|
|
||
| mi.mask[noDataBox] ^= NODATABIT # XOR to reset what we did | ||
| self.assertEqual(ipIsr.countMaskedPixels(mi, 'NO_DATA'), 0) |
There was a problem hiding this comment.
What exactly is happening in this unit test? I see all comparisons to zero. Are these null tests always? Shouldn't there be tests for when the number of masked pixels is different from zero? Maybe I misunderstood the test.
There was a problem hiding this comment.
The test above this line applies a mask bit (NO_DATA) to a region, and then checks that the count of those pixels in that mask is equal to the area of that region. The check for BAD is checking that it's correctly respecting mask planes and only measuring what it's told.
czwa
force-pushed
the
tickets/DM-35569
branch
from
d16831d
to
a97e992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move countMaskedPixels from cp_pipe, and use it to check that the amplifier is fully masked.