DM-36597: Add LATISS filter transmission data #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferte
approved these changes
Nov 14, 2022
| with cds.enable(): | ||
| # These need to be in Angstroms, for consistency. | ||
| wavelengths = wavelengths.to(u.Angstrom).to_value() | ||
| # This is ugly. Fix. |
There was a problem hiding this comment.
Does 'fix' mean 'to be fixed' or is the fix below?
There was a problem hiding this comment.
It remains ugly (to me at least), but the subsequent if line is the fix. I have deleted this comment as it was intended as an intermediate note to myself.
* Added docstrings. * Fix initialization bugs. * Fix unit bugs. * Add unit test and test data.
czwa
force-pushed
the
tickets/DM-36597
branch
from
3f80e05
to
1653a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket adds a new
IntermediateTransmissionCurvecalibration class (and subclasses) that can read a common transmission curve format (with metadata), and write anlsst.afw.image.TransmissionCurveto butler for use as a calibration.