Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37022: overscan.py parallel overscan sigma clip is really a threshold clip #240

Merged
merged 1 commit into from Nov 17, 2022
Merged

DM-37022: overscan.py parallel overscan sigma clip is really a threshold clip #240

merged 1 commit into from Nov 17, 2022

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Nov 16, 2022

Fix parallelOverscan bleed mask threshold.

@czwa czwa requested a review from erykoff November 16, 2022 22:46
erykoff
erykoff approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must ask ... is there a test for this anywhere?

@czwa
Copy link
Contributor Author

czwa commented Nov 16, 2022

I must ask ... is there a test for this anywhere?

Yes, but perhaps it's not as well designed as it could be. tests/test_overscanCorrection.py has a test_badParallelOverscanCorrection, which sets the parallel overscan to a value of 400 (essentially saturation given that the other pixel values are ~10ADU or less). That does trigger the skip case for the test exposure, which I think was all that was considered when the test was added.

@czwa czwa merged commit 9ca8237 into main Nov 17, 2022
@czwa czwa deleted the tickets/DM-37022 branch November 17, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czwa @erykoff