Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38044: Logging error in isrTask #252

Merged
merged 2 commits into from Feb 20, 2023
Merged

DM-38044: Logging error in isrTask #252

merged 2 commits into from Feb 20, 2023

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Feb 16, 2023

Fix broken log message.

@mfisherlevine
Copy link
Contributor

Looks good, thanks! General question/comment/request though: could we turn on debug level logging in some/all of the tests in here so that things like this are always being exercised and we don't run afoul of this again?

@timj
Copy link
Member

timj commented Feb 17, 2023

I think we should patch sconsUtils to turn in debug logging in all our testing rather than targeting this package

@mfisherlevine
Copy link
Contributor

I think we should patch sconsUtils to turn in debug logging in all our testing rather than targeting this package

Totally agree - I wonder if it'll break the build!

@mfisherlevine
Copy link
Contributor

I think we should patch sconsUtils to turn in debug logging in all our testing rather than targeting this package

Totally agree - I wonder if it'll break the build!

When we do that though, we must be careful to set the raiseExceptions thing so that it does actually fault though!

@timj
Copy link
Member

timj commented Feb 17, 2023

I wonder if it'll break the build

The answer is it breaks pipe_tasks...

@czwa czwa merged commit 925ef49 into main Feb 20, 2023
@czwa czwa deleted the tickets/DM-38044 branch February 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfisherlevine mfisherlevine mfisherlevine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@czwa @mfisherlevine @timj