Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39460: Bug-fix for CHARGE_SUM photodiode integration method #266

Merged
merged 4 commits into from
May 31, 2023
Merged

DM-39460: Bug-fix for CHARGE_SUM photodiode integration method #266

merged 4 commits into from
May 31, 2023

Commits on May 30, 2023

  1. exclude points that are part of the on-signal ramp from background es… 

    …timate
    @jchiang87
    jchiang87 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    e13be20 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. update expected values from .integrateChargeSum

    @jchiang87
    jchiang87 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    074a1b2 View commit details
    Browse the repository at this point in the history

  2. simplify selection of background points following Eli's suggestions

    @jchiang87
    jchiang87 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    bec9753 View commit details
    Browse the repository at this point in the history

  3. add test for integrateChargeSum failure mode

    @jchiang87
    jchiang87 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    76f75ef View commit details
    Browse the repository at this point in the history