DM-40128: Fix brighter-fatter loading errors #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move calibration date searches to runQuantum with the rest of the header provenance. * Handle inputs that change name during the header provenance (only brighter-fatter kernels currently). * Retain header validation checks in the run method.
taranu
approved these changes
Sep 5, 2023
python/lsst/ip/isr/isrTask.py
Outdated
|
|
||
| if brighterFatterKernel is None: | ||
| # This was requested by the config, but none were found. | ||
| raise RuntimeError("No brighter-fatter kernel was supplied.") | ||
|
|
||
| if brighterFatterKernel is not None and not isinstance(brighterFatterKernel, numpy.ndarray): |
There was a problem hiding this comment.
Can't this just be elif not isinstance(brighterFatterKernel, numpy.ndarray) now?
|
|
||
| # These inputs change name during this step. These should | ||
| # have matching entries in the additionalInputDates dict. | ||
| additionalInputs = [] |
There was a problem hiding this comment.
Not that it matters much but couldn't you just set this to list(inputs.keys()) to start with and append to/extend it?
There was a problem hiding this comment.
That would certainly work the same, but I think it would require some variable name and comment rewrites. I think in the long term, this can eventually go away if all cameras switch to IsrCalib style brighter-fatter kernels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify header provenance code and fix BF errors: