DM-41754: Check handling of gains in CTI code. #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-41754
branch
from
cd5ac5b
to
d0c1b48
Compare
czwa
force-pushed
the
tickets/DM-41754
branch
from
d0c1b48
to
20eaec9
Compare
erykoff
approved these changes
Nov 30, 2023
python/lsst/ip/isr/deferredCharge.py
Outdated
| self.log.info(f"useGains = {useGains} due to calibration") | ||
| else: | ||
| useGains = self.config.useGains | ||
| self.log.info(f"useGains = {useGains} due to config") |
There was a problem hiding this comment.
I think this log could give more info that USEGAINS was not found in calibration metadata or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce gain usage in CTI construction and application.