DM-41316: Refactor overscan task for IsrTaskLSST into serial/parallel tasks. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-41316
branch
2 times, most recently
from
9949fd7
to
ae8e48e
Compare
This also fixes the bug so that leading/trailing rows/columns are skipped for both serial and parallel overscan according to the configs.
Note that this masking is _not_ global, because that is incorrect.
If it's configured to skip the amps, now it can.
erykoff
force-pushed
the
tickets/DM-41316
branch
from
ae8e48e
to
745ffe4
Compare
czwa
approved these changes
Jan 9, 2024
| @@ -1014,7 +1268,7 @@ def run(self, *, ccdExposure, dnlLUT=None, bias=None, deferredChargeCalib=None, | |||
|
|
|||
| if self.config.doVariance: | |||
| # Input units: electrons | |||
| self.variancePlane(ccdExposure, detector, overscans, ptc) | |||
| self.variancePlane(ccdExposure, detector, serialOverscans, ptc) | |||
|
|
|||
| if self.config.doCrosstalk: | |||
| # Input units: electrons | |||
There was a problem hiding this comment.
This can't be correct. This may be an issue with the task not being up-to-date with the latest boxes, but this cannot be in electrons if the previous crosstalk correction is in ADU (as indicated above). Any CT non-linearity will make this unit difference a problem.
There was a problem hiding this comment.
The order here is not correct according to our latest calibration boxes, that's correct. I don't think it's good for this ticket to reorder things (that's out of scope) but we should make sure that the ordering is fixed prior to/with the testing updates.
There was a problem hiding this comment.
DM-42459 is the ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds crosstalk correction in the parallel overscan region.