DM-42238: Propagate flat pair read noises to ptcDataset #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youtsumi
approved these changes
Jan 20, 2024
czwa
requested changes
Jan 23, 2024
Alex-Broughton
force-pushed
the
tickets/DM-42238
branch
3 times, most recently
from
d79ed7a
to
ce36a14
Compare
Alex-Broughton
changed the title
Alex-Broughton
force-pushed
the
tickets/DM-42238
branch
from
ce36a14
to
9d875f3
Compare
|
General comment applicable here and elsewhere: PR names should start with the ticket name, so they're easier to track: https://developer.lsst.io/work/flow.html#make-a-pull-request |
czwa
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Can you add an entry to the unit tests to check existence and type? This line is the similar change on the previous ticket, and as ci_cpp's testing is intentionally broken for the sprint, this will at least provide something for Jenkins to check:
https://github.com/lsst/ip_isr/blob/main/tests/test_ptcDataset.py#L90
Approving this on condition a matching line is added for noiseList.
Alex-Broughton
changed the title
Alex-Broughton
force-pushed
the
tickets/DM-42238
branch
from
9d875f3
to
f802c63
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42238
branch
from
f802c63
to
e0a461a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.