DM-42666: Propagate MJD #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
commented
Jan 25, 2024
| @@ -215,11 +215,13 @@ def run(self, inputExp, ptc=None, overscanResults=None, **kwargs): | |||
| if self.config.doCopyCalibDistributionStatistics: | |||
| calibDistributionResults = self.copyCalibDistributionStatistics(inputExp, **kwargs) | |||
|
|
|||
| mjd = inputExp.getMetadata().get("MJD", None) | |||
There was a problem hiding this comment.
I'm not entirely sure if I can expect MJD to always exist. If not, can the code downstream handle None?
There was a problem hiding this comment.
It looks like None is cast to 0 by matplotlib, so that's probably safe.
czwa
approved these changes
Jan 25, 2024
| @@ -215,11 +215,13 @@ def run(self, inputExp, ptc=None, overscanResults=None, **kwargs): | |||
| if self.config.doCopyCalibDistributionStatistics: | |||
| calibDistributionResults = self.copyCalibDistributionStatistics(inputExp, **kwargs) | |||
|
|
|||
| mjd = inputExp.getMetadata().get("MJD", None) | |||
There was a problem hiding this comment.
It looks like None is cast to 0 by matplotlib, so that's probably safe.
arunkannawadi
force-pushed
the
tickets/DM-42666
branch
2 times, most recently
from
0adf3de
to
1595419
Compare
arunkannawadi
force-pushed
the
tickets/DM-42666
branch
from
1595419
to
69664d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.