Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42982: IsrTask.defineEffectivePtc warns in all(?) cases #313

Merged
merged 4 commits into from Mar 6, 2024
Merged

DM-42982: IsrTask.defineEffectivePtc warns in all(?) cases #313

merged 4 commits into from Mar 6, 2024

Conversation

plazas
Copy link
Contributor

@plazas plazas commented Mar 4, 2024

No description provided.

@plazas plazas requested a review from kfindeisen March 4, 2024 21:22
kfindeisen
kfindeisen approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by the run-time type checking, otherwise looks good.

python/lsst/ip/isr/isrTask.py Outdated Show resolved Hide resolved
plazas and others added 3 commits March 5, 2024 14:13
Check that PTC is not None in ePtc func
ffdf54d
@plazas @kfindeisen
Update python/lsst/ip/isr/isrTask.py
86ad789 
Co-authored-by: Krzysztof Findeisen <kfindeisen@users.noreply.github.com>
Import numbers
b1c999f
@plazas plazas merged commit 8c67aea into main Mar 6, 2024
2 checks passed
@plazas plazas deleted the tickets/DM-42982 branch March 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plazas @kfindeisen