Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43271: Ensure that setting doSaturation=False turns off saturation masking. #314

Merged
merged 2 commits into from
Mar 12, 2024
Merged

DM-43271: Ensure that setting doSaturation=False turns off saturation masking. #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad97228
Fix when saturation value is set.
erykoff Mar 11, 2024
eba36c8
Fix when saturation value is set in IsrTaskLSST.
erykoff Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/lsst/ip/isr/isrTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2106,11 +2106,13 @@ def maskAmplifier(self, ccdExposure, amp, defects):
# masked now, though.
limits = dict()
if self.config.doSaturation and not badAmp:
# Set to the default from the camera model.
limits.update({self.config.saturatedMaskName: amp.getSaturation()})
# And update if it is set in the config.
if math.isfinite(self.config.saturation):
limits.update({self.config.saturatedMaskName: self.config.saturation})
if self.config.doSuspect and not badAmp:
limits.update({self.config.suspectMaskName: amp.getSuspectLevel()})
if math.isfinite(self.config.saturation):
limits.update({self.config.saturatedMaskName: self.config.saturation})

for maskName, maskThreshold in limits.items():
if not math.isnan(maskThreshold):
Expand Down
6 changes: 4 additions & 2 deletions python/lsst/ip/isr/isrTaskLSST.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,11 +585,13 @@ def maskSaturatedPixels(self, badAmpDict, ccdExposure, detector):
# Mask saturated and suspect pixels.
limits = {}
if self.config.doSaturation:
# Set to the default from the camera model.
limits.update({self.config.saturatedMaskName: amp.getSaturation()})
# And update if it is set in the config.
if math.isfinite(self.config.saturation):
limits.update({self.config.saturatedMaskName: self.config.saturation})
if self.config.doSuspect:
limits.update({self.config.suspectMaskName: amp.getSuspectLevel()})
if math.isfinite(self.config.saturation):
limits.update({self.config.saturatedMaskName: self.config.saturation})

for maskName, maskThreshold in limits.items():
if not math.isnan(maskThreshold):
Expand Down