Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 8108 #36

Merged
merged 2 commits into from Apr 26, 2017
Merged

Tickets/dm 8108 #36

merged 2 commits into from Apr 26, 2017

Conversation

natelust
Copy link
Contributor

No description provided.

Copy link

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one very minor stylistic comment.

@@ -85,7 +85,9 @@ def defectListFromFootprintList(fpList, growFootprints=1):
if growFootprints > 0:
# if "True", growing requires a convolution
# if "False", its faster
fpGrow = afwDetection.growFootprint(fp, growFootprints, False)
tempSpans = fp.spans.dilated(growFootprints,
afwGeom.Stencil.MANHATTAN)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there should be an extra space in the indentation.

Obs_lsstSim defines a set of defects which falloutside the bonding
box of the pixel mask. Add in this work around until the issues is
dealt with.
@natelust natelust merged commit c001d88 into master Apr 26, 2017
@ktlim ktlim deleted the tickets/DM-8108 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants