DM-2639: {{Standardize primary method names, run/runDataRef, across PipeTasks}} #59
Conversation
| @@ -195,7 +195,7 @@ def parseAndRun(cls, *args, **kwargs): | |||
| pickle.dump(resultList, open(results.parsedCmd.dumpRatios, "w")) | |||
| return task.reduce(resultList) | |||
|
|
|||
| def run(self, dataRef): | |||
| def runDataRef(self, dataRef): | |||
There was a problem hiding this comment.
I think this is a case where runDataRef should call run since run can do useful work on the unpersisted exposure.
There was a problem hiding this comment.
The work of converting tasks to have the work done in run, and the runDataRef be the entry point for command line task is planned for after this ticket is complete. We chose to do the big outward facing api change first, and save any refactoring work for another ticket.
There was a problem hiding this comment.
This would be a trivial change. Most of the other renames do not lend themselves to adding run methods (at least that I saw in the packages I looked at) but this one did.
There was a problem hiding this comment.
In the interest in merging the changes for this ticket that refactoring depends on, @yalsayyad has helped by opening a ticket on this refactorization. DM-15311 covers this change, and I'll begin work on it next week.
Prepare Tasks for Gen3 PipelineTask conversion by: * Renaming CmdlineTask's entry method to `runDataRef`. The default CmdlineTask.TaskRunner now calls a Task's `runDataRef` method on the parsed command line inputs. `runDataRef` method can take any Gen2 Butler data products. * Renaming CmdlineTasks previous core methods (e.g. assemble, characterize) to `run` when they exist.
Rename methods according to RFC-352.
Fifteen total repositories with changes.