tickets/DM-16813 #70
Merged
tickets/DM-16813 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Dec 20, 2018
|
No issues with the code. I suggest updating the commit message to match the "best practices" guide to keep the log tidy: https://developer.lsst.io/work/flow.html#git-commit-message-best-practices |
|
It also looks like the two commits should be squashed. |
plazas
force-pushed
the
tickets/DM-16813
branch
2 times, most recently
from
58a83ce
to
9dd8809
Compare
plazas
force-pushed
the
tickets/DM-16813
branch
from
d7bc1ff
to
7f8df5d
Compare
plazas
force-pushed
the
tickets/DM-16813
branch
from
b05aa4a
to
2bf09d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check input in isrTask to raise if doCrosstalk is true and crosstalk coefficients are not found