Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-17446: overscan improperly sets bounding boxes when leading/trailing columns are skipped #73

Merged
merged 3 commits into from
Jan 30, 2019
Merged

DM-17446: overscan improperly sets bounding boxes when leading/trailing columns are skipped #73

merged 3 commits into from
Jan 30, 2019

Commits on Jan 30, 2019

  1. Fix overscan bounding box issue. 

    Setting overscanNumLeadingColumnsToSkip and
overscanNumTrailingColumnsToSkip needs to ensure that the bounding box
skips the appropriate edges.  Previously, one edge was not being
skipped, resulting in an incorrect overscan bounding box.
    @czwa
    czwa committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    868e9b1 View commit details
    Browse the repository at this point in the history

  2. Proposed fix; see slack #dm-lsstcam

    @RobertLuptonTheGood @czwa
    RobertLuptonTheGood authored and czwa committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    e404c11 View commit details
    Browse the repository at this point in the history

  3. Cleaned up bbox code

    @RobertLuptonTheGood @czwa
    RobertLuptonTheGood authored and czwa committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    f685ab5 View commit details
    Browse the repository at this point in the history