DM-17912 Fix potential KeyError in gen3 datasets. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Feb 22, 2019
The inputTypeDict and outputTypeDict are constructed with all possible
input and output datasets, and are culled based on the configuration
parameters. If the entry does not exist in the dict (possibly due to
other configurations), this can cause a KeyError. Resolve this by
using dict.pop("key", None) instead of del dict["key"].
czwa
force-pushed
the
tickets/DM-17912
branch
from
b6ead22
to
b873210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inputTypeDict and outputTypeDict are constructed with all possible
input and output datasets, and are culled based on the configuration
parameters. If the entry does not exist in the dict (possibly due to
other configurations), this can cause a KeyError. Resolve this by
using dict.pop("key", None) instead of del dict["key"].