DM-4441: Update isrMock for multi-component fringes. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
reviewed
May 23, 2019
Adding multi-component fringes to the mocks allows full tests of how FringeTask handles these fits. Return fringe solution and RMS values for validation.
| self.assertFloatsAlmostEqual(statBefore[0], 8075.6885, atol=1e-2) | ||
| self.assertFloatsAlmostEqual(statAfter[0], 8051.6206, atol=1e-2) | ||
| self.assertFloatsAlmostEqual(statBefore[0], 8070.0195, atol=1e-2) | ||
| self.assertFloatsAlmostEqual(statAfter[0], 8045.7773, atol=1e-2) |
There was a problem hiding this comment.
Could you also comment on why these test values need changing?
There was a problem hiding this comment.
As below, there was a change in the fringe size on the image, resulting in smaller median/sigma values.
| @@ -183,8 +183,8 @@ def test_flatCorrection(self): | |||
| self.task.flatCorrection(self.inputExp, flatIm) | |||
| statAfter = computeImageMedianAndStd(self.inputExp.image[self.amp.getBBox()]) | |||
| self.assertGreater(statAfter[1], statBefore[1]) | |||
| self.assertFloatsAlmostEqual(statAfter[1], 147417.36, atol=1e-2) | |||
| self.assertFloatsAlmostEqual(statBefore[1], 148.28436, atol=1e-2) | |||
| self.assertFloatsAlmostEqual(statAfter[1], 147407.02, atol=1e-2) | |||
There was a problem hiding this comment.
And here (and the ones below, etc)
There was a problem hiding this comment.
The "science" images used for these tests are generated with doAddFringe=True. To better test the multi-fringe code, the wavelength of the function was cut by a factor of 3, which results in the fringe component being significant over a smaller area. This gives slightly smaller median and sigma values (as more area is not influenced by the fringe pattern).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding multi-component fringes to the mocks allows full tests to confirm
FringeTask handles these fits. Return fringe solution and RMS values
for validation of the measured values.