DM-19214: ip_isr crosstalk shouldn't depend on detector hasCrosstalk( )and getCrosstalk() #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crosstalk application currently demands that the exposure detector have the crosstalk coefficient data included in the detector definition. This makes measuring CT on new detectors challenging, and is explicitly not used for the most well-tested cameras (HSC/DECam). This change allows the crosstalk coefficients to be set in the isr.crosstalk configuration.
To support this change, MeasureCrosstalkTask grabbed previously isolated functions into the task class, and additional debug visualization methods were added to help assess the measurement quality.