Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-20109: Improve ip_isr log messages to be more explicit #99

Merged
merged 1 commit into from Jun 20, 2019

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Jun 12, 2019

Clarify ISR log messages, comments, and docstrings.

Change isrFunctions.brighterFatterCorrection to return final
difference and iteration count, so an old log message can be restored.

Remove old out-of-date documentation that was causing build warnings.

@czwa czwa requested a review from taranu June 12, 2019 20:10
Copy link
Contributor

@taranu taranu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; see comments that are mostly minor nitpicking.

python/lsst/ip/isr/fringe.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/fringe.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/fringe.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/fringe.py Show resolved Hide resolved
python/lsst/ip/isr/fringe.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/fringe.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrTask.py Show resolved Hide resolved
python/lsst/ip/isr/isrTask.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrTask.py Show resolved Hide resolved
Change isrFunctions.brighterFatterCorrection to return final
difference and iteration count, so an old log message can be restored.

Remove old documentation that was causing build warnings.
@czwa czwa merged commit 95df18a into master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants