DM-15606: Move unit tests' retargetting a.net to configfile #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
force-pushed
the
tickets/DM-15606
branch
from
17627bf
to
dd5cfa5
Compare
parejkoj
approved these changes
Sep 28, 2018
tests/test_jointcal_hsc.py
Outdated
| self.config.astrometryRefObjLoader.retarget(LoadIndexedReferenceObjectsTask) | ||
| # use the a.net refcat for photometry. | ||
| self.config.photometryRefObjLoader.retarget(LoadAstrometryNetObjectsTask) | ||
| # use the a.net refcat for photometry gaia for astrometry |
There was a problem hiding this comment.
Missing comma: ...photometry, gaia...
yalsayyad
force-pushed
the
tickets/DM-15606
branch
2 times, most recently
from
64028bc
to
cb48cbe
Compare
Many unit tests in this package retarget LoadAstrometryNetObjectsTask and then test JointcalTask with entry point `parseAndRun()`, the CommandlineTask parser, which loads and applies the relevant obs_package config overrides. Move the astrometry and photometry RefObjLoader retargeting to a config file so that it is applied last and the unit tests are not affected by the obs_package configs.
yalsayyad
force-pushed
the
tickets/DM-15606
branch
from
cb48cbe
to
c5321d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many unit tests in this package retarget LoadAstrometryNetObjectsTask
and then test JointcalTask with entrypoint
parseAndRun(), theCommandlineTask parser, which loads and applies the relevant
obs_package config overrides.
Move the astrometry and photometry RefObjLoader retargetting to a
configfile so it is applied last and the unit tests are not
affected by the obs_package configs,