Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16235: Jointcal PhotoCalib returns negative mean calibrations #111

Merged
merged 6 commits into from
Oct 26, 2018
Merged

DM-16235: Jointcal PhotoCalib returns negative mean calibrations #111

merged 6 commits into from
Oct 26, 2018

Commits on Oct 26, 2018

  1. Add logger interface for PhotometryModel 

    Cleanup ConstrainedPhotometryModel docstring
    @parejkoj
    parejkoj committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    a595583 View commit details
    Browse the repository at this point in the history

  2. Add checkPositiveOnBBox to PhotometryModel.cc 

    Previously some of the test PhotometryModels were negative on all of their
bbox, because I hadn't thought through what a "correct" PhotoCalibMean should
be (answer: less than one!). Adding this method showed that error, which I've
fixed.
    @parejkoj
    parejkoj committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    38f87da View commit details
    Browse the repository at this point in the history

  3. Add photometryModel.validate() 

    Validate models after each fit step. AstrometryModel doesn't have any
"validation" conditions yet, but we can probably think of some later.

Cleanup the steps that happen after `fitter.minimize()`, so that we're always
logging chi2 and testing the same things.

Add getModel() for AstrometryFit/PhotometryFit (all the more reason to want a
common base class).
    @parejkoj
    parejkoj committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    af5ab64 View commit details
    Browse the repository at this point in the history

  4. Add docstrings

    @parejkoj
    parejkoj committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    7e52060 View commit details
    Browse the repository at this point in the history

  5. Use original calibration for mean

    @parejkoj
    parejkoj committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    5495fbc View commit details
    Browse the repository at this point in the history

  6. Cleanup fitter docstring

    @parejkoj
    parejkoj committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    983d7e4 View commit details
    Browse the repository at this point in the history