Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-16296: Remove escape of % in string #112

Merged
merged 3 commits into from Oct 26, 2018
Merged

Conversation

timj
Copy link
Member

@timj timj commented Oct 24, 2018

This was generating a flake8 warning before.

@timj timj requested a review from parejkoj October 24, 2018 19:48
Copy link
Collaborator

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this really does work, looks fine to me.

@timj
Copy link
Member Author

timj commented Oct 25, 2018

@parejkoj I've tweaked the PR to also use automatic file detection in pytest to be consistent with other packages. Running on Jenkins now.

@parejkoj
Copy link
Collaborator

Why did you remove the full directory tests/data/ from the ignore list? Everything in there should be ignored, always.

@timj
Copy link
Member Author

timj commented Oct 25, 2018

There's only one python file in there and I couldn't get it to work with the wildcard.

@parejkoj
Copy link
Collaborator

Even tests/data/* didn't work? or *.py? That's unfortunate, but I guess we can live with it.

Separately, why remove jointcalTestBase.py from the tests ignore list? I think including it results in a false unused test or something (because it's just the base classes, no tests itself).

@timj
Copy link
Member Author

timj commented Oct 25, 2018

pytest only looks for test_X.py files for testing. sconsUtils looks for all .py files. Since I switched to using pytest file detection I don't need to ignore the file (and ignoring the file is ignored if using pytest).

@timj timj merged commit fc0fb1b into master Oct 26, 2018
@timj timj deleted the tickets/DM-16296-jointcal branch October 26, 2018 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants