DM-15431: expand pybind11 interface #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-15431
branch
from
f03328d
to
1fd2ddf
Compare
|
The commit messages violate the guidelines for commit messages:
|
PaulPrice
approved these changes
Nov 5, 2018
python/lsst/jointcal/gtransfo.cc
Outdated
| @@ -49,6 +49,11 @@ void declareGtransfo(py::module &mod) { | |||
| "inputframe"_a, "inscribed"_a); | |||
| cls.def("getNpar", &Gtransfo::getNpar); | |||
| cls.def("offsetParams", &Gtransfo::offsetParams); | |||
| cls.def("computeDerivative", [](Gtransfo const &self, Point const &where, const double step) { | |||
There was a problem hiding this comment.
double const is LSST standard.
| cls.def("computeDerivative", [](Gtransfo const &self, Point const &where, const double step) { | ||
| GtransfoLin derivative; | ||
| self.computeDerivative(where, derivative, step); | ||
| return derivative; |
There was a problem hiding this comment.
I think this pattern (create a GtransfoLin, pass it in and then return it) indicates that the computeDerivative method should have an API that returns a new derivative object.
There was a problem hiding this comment.
The existing C++ uses of computeDerivative almost all reuse an existing array for the output. We could look at those and see if they are worth turning into what you suggest, but that's not for this ticket.
Although not used in python currently, these methods were useful for some exploratory work.
parejkoj
force-pushed
the
tickets/DM-15431
branch
from
1fd2ddf
to
2bd4cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.