DM-13270: Cleanup ccdImage and gtransfo APIs #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-13270
branch
from
3c62d1e
to
2db888c
Compare
czwa
approved these changes
Nov 29, 2018
include/lsst/jointcal/CcdImage.h
Outdated
|
|
||
| //! | ||
| Gtransfo const *getPix2CommonTangentPlane() const { return _pix2CommonTangentPlane.get(); } | ||
| std::shared_ptr<Gtransfo> const getPixToCommonTangentPlane() const { return _pixToCommonTangentPlane; } |
There was a problem hiding this comment.
Should this be getPixelToCommonTangentPlane()?
include/lsst/jointcal/CcdImage.h
Outdated
|
|
||
| //! | ||
| Gtransfo const *getPix2TangentPlane() const { return _pix2TP.get(); } | ||
| std::shared_ptr<Gtransfo> const getPixToTangentPlane() const { return _pixToTangentPlane; } |
include/lsst/jointcal/Gtransfo.h
Outdated
|
|
||
| //! the transformation from pixels to tangent plane (degrees) | ||
| GtransfoPoly getPix2TangentPlane() const; | ||
| GtransfoPoly getPixToTangentPlane() const; |
include/lsst/jointcal/Gtransfo.h
Outdated
|
|
||
| //! the transformation from pixels to tangent plane (degrees) | ||
| GtransfoPoly getPix2TangentPlane() const; | ||
| GtransfoPoly getPixToTangentPlane() const; |
include/lsst/jointcal/Gtransfo.h
Outdated
| @@ -579,55 +579,57 @@ class BaseTanWcs : public Gtransfo { | |||
|
|
|||
| //! Get a transform from pixels to tangent plane (degrees) | |||
| //! This is a linear transform plus the effects of the correction | |||
| virtual GtransfoPoly getPix2TangentPlane() const = 0; | |||
| virtual GtransfoPoly getPixToTangentPlane() const = 0; | |||
src/Gtransfo.cc
Outdated
| @@ -1300,10 +1300,10 @@ static double deg2rad(double degree) { return degree * M_PI / 180.; } | |||
| static double rad2deg(double rad) { return rad * 180. / M_PI; } | |||
|
|
|||
| /************* WCS transfo ******************/ | |||
| /************** LinPix2Tan *******************/ | |||
| /************** LinPixToTan *******************/ | |||
There was a problem hiding this comment.
LinPixelToTan here and throughout?
|
Thanks: this was done in a series of steps as I decided on better and better names for things (and then flattend into one commit), but I clearly didn't catch everything at each step of the way. I'm glad you caught those. |
* Rename sky2TP->skyToTangentPlane * Rename other ccdImage tangent plane/pixel methods and members: `X2Y`->`XToY` and cleanup TP->TangentPlane, CTP->CommonTangentPlane, etc. * Rename gtransfo subclasses: * TanPix2RaDec->TanPixelToRaDec * TanRaDec2Pix->TanRaDecToPixel * TanSipPix2RaDec->TanSipPixelToRaDec
parejkoj
force-pushed
the
tickets/DM-13270
branch
from
fb940c7
to
c207b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X2Y->XToYand cleanup TP->TangentPlane, CTP->CommonTangentPlane, etc.
Rename gtransfo subclasses: