Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-17956: Add option to output chi2 files at each outer fit iteration #127

Merged
merged 6 commits into from
Apr 2, 2019
Merged

DM-17956: Add option to output chi2 files at each outer fit iteration #127

merged 6 commits into from
Apr 2, 2019

Commits on Apr 2, 2019

  1. Refactor chi2 .csv writing to prepare for broader usage

    @parejkoj
    parejkoj committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    f48f7dc View commit details
    Browse the repository at this point in the history

  2. Add config to write chi2 contributions every outer loop

    @parejkoj
    parejkoj committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    d371fd8 View commit details
    Browse the repository at this point in the history

  3. Refactor how chi2 filenames are managed 

    Add logging of written chi2 filename, and log before exceptions are raised to
aid debugging.7
    @parejkoj
    parejkoj committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    6114010 View commit details
    Browse the repository at this point in the history

  4. Move meas/ref chi2 save methods to protected from public 

    These are only called by the public `saveChi2Contributions`, which manages
the filenames appropriately.
    @parejkoj
    parejkoj committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    ce6d40b View commit details
    Browse the repository at this point in the history

  5. Add IdentityProjectionHandler pybind11 wrapper for mocking

    @parejkoj
    parejkoj committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    4972b01 View commit details
    Browse the repository at this point in the history

  6. Add fit initialization steps chi2 file output 

    No outliers are rejected in these steps, but they move very far in chi2-space
because they are purely linear (or very nearly so) in the fitted parameters.

Added some tests (using mocks) to check that the filename prefixes are
reasonable.
    @parejkoj
    parejkoj committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    29627c8 View commit details
    Browse the repository at this point in the history