Tickets/dm 5933 #13
Tickets/dm 5933 #13
Conversation
Cleanup config fields, removing some, and moving others to the old starSelectorConfig, to be deleted later. Add astrometrySourceSelector and use the registry to configure it. Pull ccdImageList construction into separate method, with commented block containing the old starSelector in case we need to reference it in the near future. Also wrapped that with a profiling block, to help with speed tests. Rename assoc -> associations Tweak minSnr to keep relative/absolute RMS thresholds happy.
| @@ -21,7 +21,7 @@ namespace jointcal { | |||
| LSST_CONTROL_FIELD(sourceFluxField, std::string, "name of flux field in source catalog"); | |||
|
|
|||
| JointcalControl() : | |||
| sourceFluxField("base_CircularApertureFlux_7") | |||
| sourceFluxField("None") | |||
There was a problem hiding this comment.
I'm not convinced this is doing what you think it is doing, or that perhaps I don't understand something about LSST_CONTROL_FIELDS. You are setting it to "None" so that a user must specify a parameter. However "None" is still a string, and thus validate() will still succeed and the program will fail later when it tries to find the None in the schema. Wouldn't it be better to leave the control field blank, so that validate the control early, and have it throw a message about needing to set it? Again, maybe I am just not following what the control field is doing and "None" has a special meaning here.
There was a problem hiding this comment.
Hmmm... None doesn't have special meaning, I just wanted to set it to something that was clearly not a valid field. Previously, jointcal was cout<<'ing the above value somewhere further down the line even though I set a different value for sourceFluxField later on. I made this change to ensure it wasn't pulling something else out of the schema. Validate only checks that the field isn't empty, nothing more.
I can't set it to a blank string because validate() will fail during instantiation.
I want to totally remove sourceFluxField in the future: I don't think we actually need it, but tearing it out is not going to be easy.
Use astrometrySourceSelector to select sources.