Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working integration test for CFHT data. #14

Merged
merged 7 commits into from
Aug 2, 2016
Merged

Commits on Jul 21, 2016

  1. Working integration test for CFHT data.

    Major refactor of testing code to use new JointcalTestBase, pulling most of the
    work out of the old testJointcal.py (which is now testJointcal_lsstSim.py, and
    which now uses the base class). New testJointcal_cfht uses this base class. Also
    improved plotting code to generate per-visit quiver plots.
    
    testJointcal_lsstSim doesn't use the parseAndRun code, because the lsstSim data
    is missing some necessary metadata. Can't solve that until the new metadata
    class is built and the twinkles data is reprocessed. The test code still works
    fine, though.
    
    Improved some docstrings in jointcal.py. Left in the commented-block that used
    the old StarSelector: I think we can remove it when we have a few more robust
    source flags to describe good astrometric sources.
    
    Jointcal.run() now returns a struct with the modified dataRefs and the old WCSs.
    
    JointcalRunner now works correctly with parseAndRun, fixing DM-6915. Also made
    it return a Struct for testing the results.
    
    Added coaddName back to JointcalConfig (parseAndRun needs it).
    parejkoj committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    94c04fd View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2016

  1. Post review updates.

    Better documentation of relative and absolute error thresholds.
    
    New and improved plotting code for interpreting results.
    
    Pulled various blocks into short helper functions.
    
    Began moving test files to _ variable names.
    parejkoj committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    f8994ec View commit details
    Browse the repository at this point in the history
  2. Better visit_list management.

    Forgot to commit updated cfht tests.
    parejkoj committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    1238345 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2016

  1. Configuration menu
    Copy the full SHA
    0b478a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bef3ff1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be8c48a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7cf737f View commit details
    Browse the repository at this point in the history