DM-17830: Use only stars in internal jointcal fitting #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was already reviewed in lsst/obs_subaru#187 |
and limit to isolated stars with SNR > 10. This config shows improvement in the photometric repeatability and match to the reference catalog. * Revert to astrometry source selector in unit tests that check equality in metrics when jointcal run on testdata. * Remove some now-redundant config overrides in those affected unit tests.
yalsayyad
force-pushed
the
tickets/DM-17830
branch
from
4e16c15
to
9251161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and limit to isolated stars with SNR > 10.
This config shows improvement in the photometric repeatability
and match to the reference catalog.
that check equality in metrics when jointcal run on testdata.
affected unit tests.