Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-19768: Fix jointcal handling of coordinate errors #143

Merged
merged 5 commits into from
May 29, 2019

Commits on May 23, 2019

  1. Configuration menu
    Copy the full SHA
    072fca3 View commit details
    Browse the repository at this point in the history
  2. Use .lower() for comparisons with astrometry/photometry name

    The astrometry/photometry name passed to _do_load_refcat_and_fit() used to be
    capitalized, but that changed long ago. Either way, I should have made the
    comparisons against the name use .lower() to catch both cases. This should
    fix a few bugs that are not properly exercised by the jointcal tests.
    parejkoj committed May 23, 2019
    Configuration menu
    Copy the full SHA
    ab3e747 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary lines

    The reference selectors were being set by the caller; these lines were just
    wrong (it should have been self.X, not self.config.X)!
    parejkoj committed May 23, 2019
    Configuration menu
    Copy the full SHA
    b1bf8be View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Cleanup colorterm validation

    Review comments suggested clarifications in config validation, since
    colorterms are only applied for photometry.
    parejkoj committed May 29, 2019
    Configuration menu
    Copy the full SHA
    f166501 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5944ecf View commit details
    Browse the repository at this point in the history