Tickets/dm 6622 #15
Merged
Tickets/dm 6622 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # than the single-epoch astrometry (about 0.040"). | ||
| # This value was empirically determined from the first run of jointcal on | ||
| # this data, and will likely vary from survey to survey. | ||
| absolute_error = 52e-3*u.arcsecond |
There was a problem hiding this comment.
Is there a reason you use units.arcsecond here, but lsst.afw.geom.arcseconds later? Please use one or the other throughout if possible.
There was a problem hiding this comment.
geom.arcseconds doesn't play well with matplotlib histogram (or most numpy functions). @TallJimbo 's response to questions about plt.hist() and geom.Angle interactions was to say he'd rather work on getting Angle in python just be a Quantity.
But, I need to use Angle right now in the constructor for afw classes.
Needs validation_data_hsc at present. Add optional dependency on hsc data for testing
Initialize sourceFluxType with a value in the JointcalControl constructor. Default to Calib fluxes in AstrometrySourceSelector: using a different flux type can affect the fitting accuracy.
parejkoj
force-pushed
the
tickets/DM-6622
branch
from
6e5b6e3
to
bd6fd2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.