Tickets/dm 6627 #16
Merged
Tickets/dm 6627 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,23 +40,45 @@ class JointcalRunner(pipeBase.TaskRunner): | |||
|
|
|||
| @staticmethod | |||
| def getTargetList(parsedCmd, **kwargs): | |||
| """ | |||
| Return a list tuples per tract: (dataRefs, kwargs). | |||
There was a problem hiding this comment.
This could be clearer. How about "Return a list of tuples, one per tract:" and then explaining what is in kwargs?
parejkoj
force-pushed
the
tickets/DM-6627
branch
2 times, most recently
from
f0c19ca
to
4880d0e
Compare
| @@ -20,9 +20,9 @@ namespace jointcal { | |||
| struct JointcalControl { | |||
| LSST_CONTROL_FIELD(sourceFluxField, std::string, "name of flux field in source catalog"); | |||
|
|
|||
| JointcalControl(std::string const sourceFluxType) : | |||
| JointcalControl(std::string const _sourceFluxField="slot_CalibFlux") : | |||
There was a problem hiding this comment.
I suggest passing by reference (const & instead of const). I also suggest using the same variable name as the attribute (no leading underscore); I admit that can look a bit confusing, but it works and is fairly normal C++. In any case a leading underscore should be reserved to indicate "private" (or protected)
There was a problem hiding this comment.
Fixed both. Thanks.
Initialize sourceFluxType with a value in the JointcalControl constructor. Default to Calib fluxes in AstrometrySourceSelector: using a different flux type can affect the fitting accuracy.
parejkoj
force-pushed
the
tickets/DM-6627
branch
from
72400e7
to
a42f7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use slot_* for various fields and cleanup JointcalControl.