DM-25779: Investigate jointcal chi2 changes in a large HSC run #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-25779
branch
2 times, most recently
from
7655685
to
5496e85
Compare
isullivan
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Looks good. I don't think you also need to plot the reduced chi2, since you put the raw chi2 and degrees of freedom plots side-by-side and in the example you showed on Jira it was easy to tell whether movement in the chi2 plot was coming from the fit or changes in the number of degrees of freedom.
parejkoj
force-pushed
the
tickets/DM-25779
branch
from
5496e85
to
8c6f85a
Compare
parejkoj
force-pushed
the
tickets/DM-25779
branch
from
8c6f85a
to
075bbbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.