Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27170: Deprecate and phase out afw::image::Filter #166

Merged
merged 2 commits into from Jan 29, 2021

Conversation

parejkoj
Copy link
Collaborator

@parejkoj parejkoj commented Jan 2, 2021

No description provided.

python/lsst/jointcal/jointcal.py Outdated Show resolved Hide resolved
python/lsst/jointcal/jointcal.py Outdated Show resolved Hide resolved
@parejkoj parejkoj force-pushed the tickets/DM-27170 branch 2 times, most recently from 1cdb1a0 to aa652a1 Compare January 14, 2021 08:42
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks very explicit now.

Use physical filter names for jointcal's internal CcdImage structure to
distinguish e.g. HSC-R and HSC-R2 if we ever support a multi-filter mode.

Change "filter" to "band" throughout the jointcal.py to make the type of label
more clear. In this case it is used to load refcats, which expect a band.
@parejkoj parejkoj merged commit c8ca178 into master Jan 29, 2021
@parejkoj parejkoj deleted the tickets/DM-27170 branch January 29, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants