Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-28597: Fix colorterm/photoCal filterLabel confusion #174

Merged
merged 3 commits into from Mar 31, 2021
Merged

DM-28597: Fix colorterm/photoCal filterLabel confusion #174

merged 3 commits into from Mar 31, 2021

Commits on Mar 31, 2021

  1. Cleanup physical/band filterLabel use 

    * Colorterms are now explicitly keyed on physical label, while the
refcat loader uses band, so we need to pass around FilterLabel objects.
* No need to return band in _build_ccdImage() since the caller will
always have it via JointcalInputData.
* cleanup tests that passed filters around
    @parejkoj
    parejkoj committed Mar 31, 2021
    Copy the full SHA
    f5ca8f4 View commit details
    Browse the repository at this point in the history

  2. Add check on having no valid data to gen3 load

    @parejkoj
    parejkoj committed Mar 31, 2021
    Copy the full SHA
    bb8d892 View commit details
    Browse the repository at this point in the history

  3. Protect tests from colliding FilterDefinitions 

    Now that obs_cfht is using FilterDefinitionCollections, we have to use
that to reset them, and we need to protect any uses of
`createTwoFakeCcdImages`, since those create a Camera.
    @parejkoj
    parejkoj committed Mar 31, 2021
    Copy the full SHA
    ca6021d View commit details
    Browse the repository at this point in the history