Jointcal test for decam Tickets/dm 6624 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtpatter
reviewed
Nov 30, 2016
| @@ -159,7 +159,7 @@ def _build_ccdImage(self, dataRef, associations, jointcalControl): | |||
| uRight = afwGeom.Point2I(lLeft.getX() + md.get("NAXIS1")-1, lLeft.getY() + md.get("NAXIS2")-1) | |||
There was a problem hiding this comment.
I know it's not edited on this PR, but noting that our style guide says there should be whitespace around the subtraction signs.
There was a problem hiding this comment.
Same for the modulus operator used for string formatting on lines 169, 220, and 297.
| self.all_visits = [176837, 176846] | ||
| ccdnums = '^'.join(str(x) for x in range(10,19)) |
There was a problem hiding this comment.
Should there be whitespace after the comma in range?
| self.all_visits = [176837, 176846] | ||
| ccdnums = '^'.join(str(x) for x in range(10,19)) | ||
| self.other_args = ['ccdnum='+ccdnums,] |
There was a problem hiding this comment.
Whitespace after the comma (E231) and also around the + operator (according to the style guide).
| self.all_visits = [176837, 176846] | ||
| ccdnums = '^'.join(str(x) for x in range(10,19)) | ||
| self.other_args = ['ccdnum='+ccdnums,] | ||
|
|
||
| @unittest.skipIf(data_dir is None, "validation_data_decam not setup") |
There was a problem hiding this comment.
Do you want this to say validation_data_jointcal not setup?
Update to new decam testdata location. Cleanup pep8 formatting
parejkoj
force-pushed
the
tickets/DM-6624
branch
from
f654e78
to
525d12a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working version of a jointcal test for decam data, post-VisitInfo.