DM-24278: Apply proper motion to matched sources in Jointcal #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-format
I think if this happens it should be an error, as this could cause the fitter to fail. I don't know if I need to actually fail here, but the log message should be more obvious.
parejkoj
force-pushed
the
tickets/DM-24278
branch
from
7cd31d0
to
5624b44
Compare
kgabor
approved these changes
Jun 26, 2021
Add ProperMotion C++ class and test_star to compare it with astropy. Proper Motions won't be fit, they are just applied to the FittedStars whose MeasuredStars have a matched RefStar with proper motions. Cleanup now irrelevant Assocations PM code (NPAR_PM constant): until we have real code to fit PM values, this is just clutter. mjd -> epochYear cleanup: *Refactor python epoch handling, to compute it earlier. *Remove unused mjd/JDRef dates and add epoch. *Use year delta in PM calculations. *Fix test math of mean proper motion epoch, converting mjd to epoch year.
The refraction code here has not been used in ages, and we are not supplying relevant color information as input anyway.
parejkoj
force-pushed
the
tickets/DM-24278
branch
from
102ebf1
to
7a4ded7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented on this ticket, the new PM corrections do not include PM uncertainty which will be done on DM-30383.