DM-30534: Turn off config parameter from obs_subaru for tests #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, in the interest of future-proofing for RFC-775 (we want to eventually decouple the obs-package configs, and the jointcal test configs), can we instead have an explicit setting in |
cmsaunders
force-pushed
the
tickets/DM-30534
branch
from
2dd2d35
to
b15e20b
Compare
cmsaunders
changed the title
laurenam
reviewed
Jul 11, 2021
tests/config/hsc-config.py
Outdated
| @@ -1,2 +1,3 @@ | |||
| # no colorterms in tests unless specifically requested (this overrides the default HSC config) | |||
| config.applyColorTerms = False | |||
| config.astrometryOutlierRelativeTolerance = False | |||
There was a problem hiding this comment.
The docs have this as type float, not bool, so I believe this should be set to 0. Also, you need a carriage return.
I found the commit message a tad confusing as you are not actually removing the use of obs_subaru here.
Following RFC-775 and DM-30899, jointcal should not use obs_* packages. Testing of the config parameter astrometryOutlierRelativeTolerance is also already done in `jointcal/tests/test_jointcal_cfht.py`. Thus, it should be turned off in `jointcal/tests/config/hsc-config.py`.
cmsaunders
force-pushed
the
tickets/DM-30534
branch
from
b15e20b
to
ef3946f
Compare
cmsaunders
changed the title
laurenam
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of the astrometryOutlierRelativeTolerance config
parameter has been changed in obs_subaru, so the expected values of chi2
and ndof change in some tests.