DM-30927: Set calexp WCS to None for failed astrometric fit #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-30927
branch
from
9736412
to
c862146
Compare
laurenam
force-pushed
the
tickets/DM-30927
branch
from
c862146
to
2b33bad
Compare
laurenam
force-pushed
the
tickets/DM-30927
branch
from
2b33bad
to
d9739f0
Compare
laurenam
force-pushed
the
tickets/DM-30927
branch
from
d9739f0
to
6a0fae9
Compare
laurenam
force-pushed
the
tickets/DM-30927
branch
from
6a0fae9
to
cb51f12
Compare
erykoff
reviewed
Sep 14, 2022
python/lsst/jointcal/jointcal.py
Outdated
| @@ -799,6 +802,8 @@ def _load_data(self, inputSourceTableVisit, inputVisitSummary, associations, | |||
| visitCatalog = dataRef.get(parameters={'columns': columns}) | |||
|
|
|||
| selected = self.sourceSelector.run(visitCatalog) | |||
| if len(selected) == 0: | |||
| raise RuntimeError("No data to process: the source selector removed all sources") | |||
There was a problem hiding this comment.
Wait, should this actually raise if one of the visits has no sources?
There was a problem hiding this comment.
Hhhmmm...good point. Do you think I should just log a message (INFO/WARNING?) and continue?
laurenam
force-pushed
the
tickets/DM-30927
branch
2 times, most recently
from
c31acc6
to
53171bf
Compare
erykoff
reviewed
Sep 21, 2022
python/lsst/jointcal/jointcal.py
Outdated
| @@ -799,6 +802,10 @@ def _load_data(self, inputSourceTableVisit, inputVisitSummary, associations, | |||
| visitCatalog = dataRef.get(parameters={'columns': columns}) | |||
|
|
|||
| selected = self.sourceSelector.run(visitCatalog) | |||
| if len(selected) == 0: | |||
There was a problem hiding this comment.
This line is incorrect, selected is a struct. You need len(selected.sourceCat).
We are now persisting source catalogs even in light of an astrometric failure in single frame processing. Such catalogs will have their sky coordinate column (typically "coord_ra" and "coord_dec") values set to NaN. They are thus not suitable for inclusion in the jointcal calibration, so this config default ensures they are omited from the selection of "good" sources.
laurenam
force-pushed
the
tickets/DM-30927
branch
from
53171bf
to
b70a6be
Compare
erykoff
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.