DM-31825: Add columnar access to source tables and support new table column names #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
approved these changes
Sep 28, 2021
parejkoj
reviewed
Sep 28, 2021
python/lsst/jointcal/jointcal.py
Outdated
| visitCatalog = inputSourceTableVisit[catalogMap[visitSummaryRef.dataId['visit']]].get() | ||
|
|
||
| dataRef = inputSourceTableVisit[catalogMap[visitSummaryRef.dataId['visit']]] | ||
| if isinstance(dataRef, dafPersist.ButlerDataRef): |
There was a problem hiding this comment.
This shouldn't be necessary here at all: this method is only called when running in gen3.
erykoff
force-pushed
the
tickets/DM-31825
branch
from
217f2b3
to
fdea28c
Compare
parejkoj
reviewed
Sep 28, 2021
| @@ -885,15 +884,24 @@ def _load_data(self, inputSourceTableVisit, inputVisitSummary, associations, | |||
| catalogMap = {ref.dataId['visit']: i for i, ref in enumerate(inputSourceTableVisit)} | |||
| detectorDict = {detector.getId(): detector for detector in camera} | |||
|
|
|||
| columns = None | |||
There was a problem hiding this comment.
Please add a note here about how this is filled out with the columns to be load from the sourceTable during the first loop iteration.
parejkoj
reviewed
Sep 28, 2021
| @@ -920,6 +928,53 @@ def _make_one_input_data(self, visitRecord, catalog, detectorDict): | |||
| filter=lsst.afw.image.FilterLabel(band=visitRecord['band'], | |||
| physical=visitRecord['physical_filter'])) | |||
|
|
|||
| def _get_sourceTable_visit_columns(self, inColumns): | |||
| """ | |||
| Get the sourceTable_visit columns from the config. | |||
There was a problem hiding this comment.
I wonder if this is something we can put somewhere more general? I don't know if a tweak of this is generally applicable for code that reads the visit-level tables?
yalsayyad
force-pushed
the
tickets/DM-31825
branch
from
fdea28c
to
e4b2fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.