DM-32207: Add physical_filter to metrics dimensions. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Oct 12, 2021
tests/test_jointcal_hsc.py
Outdated
| @@ -147,6 +147,15 @@ def check_output(visit, detectors): | |||
| check_output(34648, [51, 59, 67]) | |||
| check_output(34690, [48, 56, 64]) | |||
|
|
|||
| def test_jointcalTask_r_visits_2_bands_simple_gen3_dm32207(self): | |||
There was a problem hiding this comment.
I'm not sure what r_visits is saying here. If both visits are r-band, I think it will trigger the error, but the name and doc string are ambiguous to me.
There was a problem hiding this comment.
I didn't even notice that, just copypasta.
| @@ -294,43 +294,43 @@ class JointcalTaskConnections(pipeBase.PipelineTaskConnections, | |||
| doc=f"The number of cross-matched fittedStars for {name}", | |||
| name=f"metricvalue_jointcal_{name}_matched_fittedStars", | |||
| storageClass="MetricValue", | |||
| dimensions=("instrument", "skymap", "tract"), | |||
| dimensions=("skymap", "tract", "instrument", "physical_filter"), | |||
There was a problem hiding this comment.
Out of curiosity, why the change in order? Do we have a canonical order for listing dimensions?
There was a problem hiding this comment.
I changed the order to match the quantum dimensions. I don't think it matters, I hope.
erykoff
force-pushed
the
tickets/DM-32207
branch
from
b6cf034
to
7f56b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.