DM-32487: Adjust flags and tests to support osx-arm64 #203
Conversation
|
|
||
| uname = os.uname() | ||
| if uname.sysname == 'Darwin' and uname.machine == 'arm64': | ||
| flags.append('-faligned-allocation') |
There was a problem hiding this comment.
Is there a down side to using that on intel macOS as well?
There was a problem hiding this comment.
If it ain't broke...
But I don't know.
There was a problem hiding this comment.
Looks like it's only available for C++17 compilers.
-faligned-allocation Enable C++17 aligned allocation functions
We are meant to be using C++17 these days but this is presumably fall out from us insisting on using an old macOS deployment target on Intel.
There was a problem hiding this comment.
Yes, a little more research (and as noted in the ticket description) I think that the deployment target that we have as a default on x86 will make this impossible to have as the universal default.
There was a problem hiding this comment.
Enabling C++17 compilation doesn't necessarily enable library support for it. MacOSx way to be backwards
compatible with old deployment targets.
Note that the astropy vs Rubin proper motion comparison test needed to be relaxed because the astropy value (used as a comparison) is varies depending on architecture.