DM-29884: Fix exception in Gen3+applyColorTerms #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we squash your commits into one single (or two) commit(s), John? |
|
Something in how you did your pull messed up my commits: I should only have two, one for the colorterm in the test, the other for the config fix. |
arunkannawadi
force-pushed
the
tickets/DM-29884
branch
from
7d007f9
to
f833690
Compare
|
I dropped your earlier set of commits and it should be fine now. I had divergent paths and my commits acting somehow as merge commits 🤷🏼 |
arunkannawadi
force-pushed
the
tickets/DM-29884
branch
from
a8479f3
to
8295d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done jointly with @natelust and @parejkoj