DM-32601: Move remaining jointcal tests to gen3 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-32601
branch
from
ca8623c
to
2dcb116
Compare
Remove center/radius and put the data centers in the testdata_jointcal README instead. Move instrumentClass and instrumentName into setUp_base. Remove gen2 test args, class attrs, and test methods. Add tests that the correct number of gen3 output products were written. Cleanup cfht and cfht_minimal tests to use new base class features.
parejkoj
force-pushed
the
tickets/DM-32601
branch
from
2dcb116
to
2aa0a3b
Compare
Remove some tests that were made redundant by converted gen3 CFHT tests or other HSC tests that are now converted. Cleanup some tests to use common setup methods to clarify metric values. Update metrics of the 10_visits test, because gen3 runs the r/i data separately; gen2 fit all filters together.
parejkoj
force-pushed
the
tickets/DM-32601
branch
from
2aa0a3b
to
f00fe6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.