DM-32601-docfix: fix pipelines build #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* utils was removed on DM-32601 (which broke the pipelines doc build) * dataIds is gen2 only, and will be removed in the future, so might as well deal with it now before we break the doc build again.
ktlim
approved these changes
Dec 21, 2021
ktlim
reviewed
Dec 21, 2021
| stored in a Camera. | ||
| e.g.: np.polyfit(self.fieldAngle, self.radialScale, poly_degree)) | ||
| stored in a Camera. e.g.: | ||
| np.polyfit(self.fieldAngle, self.radialScale, poly_degree)) |
There was a problem hiding this comment.
Unbalanced parentheses here. Does it need formatting (e.g. "`")? Indentation? Or it doesn't matter because it's temporary?
There was a problem hiding this comment.
I'm not going to worry about it (other than the parentheses), since it's entirely a placeholder.
I forgot to add this when I added the CameraModel class. Fix indentation to prevent doc warning.
parejkoj
force-pushed
the
tickets/DM-32601-docfix
branch
from
efc5ccb
to
36bb3ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DM-32601 broke the pipelines build by not removing jointcal.utils from the automodapi block in index.rst.
This branch also adds an automodapi that was missed when a new module was added.