DM-33613: modernize with clang tidy, fix obvious code defects #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Mar 31, 2022
| lsst::jointcal::JointcalControl const &control); | ||
|
|
||
| /** | ||
| * Add a pre-constructed ccdImage to the ccdImageList. | ||
| */ | ||
| void addCcdImage(std::shared_ptr<CcdImage> const ccdImage) { ccdImageList.push_back(ccdImage); } | ||
| void addCcdImage(std::shared_ptr<CcdImage> const& ccdImage) { ccdImageList.push_back(ccdImage); } |
There was a problem hiding this comment.
I think this one should be const std::...<>& ccdImage?
| std::string const &filter, std::shared_ptr<afw::image::PhotoCalib> photoCalib, | ||
| CcdImage(afw::table::SourceCatalog &record, const std::shared_ptr<lsst::afw::geom::SkyWcs>& wcs, | ||
| const std::shared_ptr<lsst::afw::image::VisitInfo>& visitInfo, lsst::geom::Box2I const &bbox, | ||
| std::string filter, std::shared_ptr<afw::image::PhotoCalib> photoCalib, |
There was a problem hiding this comment.
I'm pretty sure we can also make the photoCalib pointer const & while we're at it.
mwittgen
force-pushed
the
tickets/DM-33613
branch
from
77124d0
to
e05ac81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.