DM-10227: Replace raw arrays with std::vector #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Apr 4, 2022
src/StarMatch.cc
Outdated
| @@ -245,7 +244,7 @@ double computeDist2(const StarMatchList &starMatchList, const AstrometryTransfor | |||
|
|
|||
| double computeChi2(const StarMatchList &starMatchList, const AstrometryTransform &transform) { | |||
| unsigned s = starMatchList.size(); | |||
| std::unique_ptr<double[]> chi2s(chi2_array(starMatchList, transform)); | |||
| std::vector<double> chi2s(chi2_array(starMatchList, transform)); | |||
src/StarMatch.cc
Outdated
| const AstrometryTransform &transform) { | ||
| unsigned s = starMatchList.size(); | ||
| auto res = std::unique_ptr<double[]>(new double[s]); | ||
| std::vector<double> res(s,0.); |
There was a problem hiding this comment.
While we're at it, lets replace res->result and s->size.
There was a problem hiding this comment.
Done.
std::vector<double> result also does not need to be default intialized
| @@ -116,12 +115,12 @@ void StarMatchList::refineTransform(double nSigmas) { | |||
| if (npair == 0) break; // should never happen | |||
|
|
|||
| // compute some chi2 statistics | |||
| std::unique_ptr<double[]> chi2_array(new double[npair]); | |||
| std::vector<double> chi2_array(npair); | |||
There was a problem hiding this comment.
Done. Also use ranged based loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.