Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35897: Minor gen2 and logging cleanup #230

Merged
merged 3 commits into from Aug 16, 2022
Merged

DM-35897: Minor gen2 and logging cleanup #230

merged 3 commits into from Aug 16, 2022

Conversation

timj
Copy link
Member

@timj timj commented Aug 15, 2022

  • Remove unused gen2 code
  • Use python logging in python code.

@timj
Remove two vestigial gen2 methods
6c447d2
@timj
Use python logging in python code
2cb014e 
Also use lsst.jointcal logger for the warning message
rather than a root logger. The root logger is no longer
controlled by default in the execution environment.
parejkoj
parejkoj approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this one. Sorry I missed those two methods. This looks good.

@timj
Port photo calib plotting to gen3
e1e36fe 
Tested with ci_hsc_gen3 repository.
parejkoj
parejkoj approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works on ci_hsc_gen3, then that's probably good enough. I would want to rethink how the detectors are selected and how the image is built, if we want to move this into e.g. analysis_drp (where it probably should live).

@timj timj merged commit 3a93638 into main Aug 16, 2022
@timj timj deleted the tickets/DM-35897 branch August 16, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @parejkoj