DM-25132: Update refcat loading to work with refcat v2 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Nov 17, 2022
cmsaunders
force-pushed
the
tickets/DM-25132
branch
from
ae91623
to
8f3edab
Compare
kfindeisen
approved these changes
Dec 13, 2022
src/Associations.cc
Outdated
| @@ -250,7 +250,7 @@ void Associations::collectRefStars(afw::table::SimpleCatalog &refCat, geom::Angl | |||
|
|
|||
| // TODO: we aren't getting covariances from Gaia yet, so maybe ignore this for now? | |||
| try { | |||
| pmRaDecCovKey = refCat.getSchema().find<float>("pm_ra_Dec_Cov").key; | |||
| pmRaDecCovKey = refCat.getSchema().find<float>("pm_dec_pm_ra_Cov").key; | |||
There was a problem hiding this comment.
Suggested change
| pmRaDecCovKey = refCat.getSchema().find<float>("pm_dec_pm_ra_Cov").key; | |
| pmRaDecCovKey = refCat.getSchema().find<float>("pm_ra_pm_dec_Cov").key; |
There was a problem hiding this comment.
Thanks for catching this. There is no test coverage of this, probably because jointcal doesn't actually do anything with raDecCov.
cmsaunders
force-pushed
the
tickets/DM-25132
branch
from
8f3edab
to
c63f907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.