Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37720: use pybind wrappers, merge into one pybind shared lib #235

Merged
merged 3 commits into from Feb 27, 2023
Merged

DM-37720: use pybind wrappers, merge into one pybind shared lib #235

merged 3 commits into from Feb 27, 2023

Conversation

mwittgen
Copy link
Contributor

No description provided.

@mwittgen mwittgen force-pushed the tickets/DM-37720 branch 5 times, most recently from 82c5672 to 84d0cb5 Compare January 27, 2023 22:43
erykoff
erykoff reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments on imports. But more importantly, I'm not sure why we need the compatibility stubs here? Nobody is importing from jointcal, so isn't the key to fix any internal imports?

python/lsst/jointcal/associations.cc Outdated Show resolved Hide resolved
python/lsst/jointcal/astrometryTransform.cc Outdated Show resolved Hide resolved
@mwittgen mwittgen force-pushed the tickets/DM-37720 branch 2 times, most recently from 68203f5 to cb47d76 Compare February 14, 2023 22:20
@mwittgen
Copy link
Contributor Author

Rebased. Removed all compatibility stubs and updated tests accordingly.

erykoff
erykoff approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a few funny inadvertent license replacements.

python/lsst/jointcal/photometryTransform.cc Outdated Show resolved Hide resolved
python/lsst/jointcal/projectionHandler.cc Outdated Show resolved Hide resolved
python/lsst/jointcal/star.cc Outdated Show resolved Hide resolved
@mwittgen mwittgen merged commit e7e798a into main Feb 27, 2023
@mwittgen mwittgen deleted the tickets/DM-37720 branch February 27, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwittgen @erykoff